[Webkit-unassigned] [Bug 32157] New: [Android] jni_utility includes two JSC-specific functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32157

           Summary: [Android] jni_utility includes two JSC-specific
                    functions
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Android
        OS/Version: Android
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: steveblock at google.com
                CC: darin at apple.com, andersca at apple.com,
                    kdecker at apple.com, snej at chromium.org,
                    android-webkit-unforking at google.com
            Blocks: 32154


jni_utility mostly provides a number of script-engine-independent helper
functions. In addition it provides two JSC-specific functions -
convertValueToJValue and dispatchJNICall. This causes problems on Android,
where we can build with JSC or V8. See Bug 32154, which this bug blocks.

It seems that jni_utility should provide only the script-engine-independent
functions. The two JSC-specific functions it currently provides are only used
within bridge/jni, so should be moved to a separate, private header. Perhaps
jni_utility_private?

The V8-specific equivalents to these functions, which are required by Android,
can then be added to this file with the necessary guards, or the file can be
split into two. Perhaps [jsc|v8]/jni_utility_private? Note that code in other
files in bridge/jni will also require separation into JSC and V8 variants.
Given this, splitting the files into two directories seems the cleanest choice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.