[Webkit-unassigned] [Bug 32149] [Qt] Doing right-click/Reload on a QWebInspector widget will close the widget

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32149


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44301|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-12-04 04:49:34 PST ---
(From update of attachment 44301)

> +    WebInspector(QWidget* parent) : QWebInspector(parent) {}
> +signals:
> +    void visibilityChanged(bool nowVisible);

Qt already has a visibleChanged (slightly different name) for the
QGraphicsObjects. Maybe we should use the same naming?


> +        QAction *showInspectorAction = toolsMenu->addAction("Show inspector", inspector, SLOT(setVisible(bool)));
> +        showInspectorAction->setCheckable(true);
> +        showInspectorAction->setShortcuts(QList<QKeySequence>()<<QKeySequence(tr("F12")));

I guess I would prefer spaces before and after the <<

But in general it LGTM. If you find it needed, make these changes before you
commit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.