[Webkit-unassigned] [Bug 32095] Chromium WebKit API needs a wrapper for WebCore::RegularExpression
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 3 23:55:01 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=32095
--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2009-12-03 23:55:00 PST ---
> > You haven't included the definition of WebStringCaseSensitivity in this
> > patch. I think it'd be better to call it WebTextCaseSensitivity. (We
> > have enums like WebTextDirection and WebTextAffinity already, so the
> > WebText prefix is common already.)
> >
>
> Done. I added the WebTextCaseSensitivity enum definition to WebString.h
> instead of creating a new file because this matches the definition of
> TextCaseSensitivity in StringImpl.h. I can make a new file if you think that's
> a better option.
Sorry, I should have made that clear. Every top-level type in the WebKit API
should have its own header file. You should see that that rule is applied
universally throughout the API.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list