[Webkit-unassigned] [Bug 32117] REGRESSION (r51627): 3 SVG tests are failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32117





--- Comment #6 from Adam Roben (aroben) <aroben at apple.com>  2009-12-03 12:38:40 PST ---
(From update of attachment 44261)

> +    template<typename ItemPtr>
> +    struct SVGListTraits<true, ItemPtr*> {
> +        static ItemPtr nullItem() { return 0; }
> +        static bool isNull(ItemPtr it) { return !it; }
> +    };

Shouldn't that be:

static ItemPtr* nullItem() { return 0; }
static bool isNull(ItemPtr* it) { return !it; }

> +        static bool isNull(RefPtr<ItemPtr> it) { return !it; }

This would be more efficient if it took a reference to const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.