[Webkit-unassigned] [Bug 32125] New: [check-webkit-style] strcmp should be excepted from readability/comparison_to_zero

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32125

           Summary: [check-webkit-style] strcmp should be excepted from
                    readability/comparison_to_zero
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abarth at webkit.org
                CC: ap at webkit.org, levin at chromium.org


Comment #7 From WebKit Review Bot 2009-12-03 10:36:46 PST (-) [reply] 
Attachment 44255 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/KURL.cpp:637:  Tests for true/false, null/non-null, and
zero/non-zero should all be done without equality comparisons. 
[readability/comparison_to_zero] [5]
Total errors found: 1

 Comment #8 From Alexey Proskuryakov 2009-12-03 10:41:21 PST (-) [reply] 
I think that strcmp comparisons should be an exception to the rule, but I can
change this when landing if a reviewer tells me to.

https://bugs.webkit.org/show_bug.cgi?id=32085#c8

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.