[Webkit-unassigned] [Bug 31591] [Qt] Crashing tests after updating to Qt-4.6.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31591


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44230|review?                     |review-
               Flag|                            |




--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-12-03 05:29:23 PST ---
(From update of attachment 44230)

> +    /*
> +    * Create a dummy container object to track the page in DRT.
> +    * QObject is used instead of QWidget to prevent DRT from
> +    * showing the main view when deleting the container.
> +    */

Please use // comment style inside code. That is our style

> +    QObject* container = new QObject(m_mainView);
> +    //create a QWebPage we want to return

Missing space between // and create

> +    QWebPage* page =static_cast<QWebPage*>(new WebPage(container, this));

Missing space after =

> +    //gets cleaned up in closeRemainingWindows()
>      windows.append(container);

same thing

> +
> +    //connect the needed signals to the page

same thing

> +    connect(page, SIGNAL(frameCreated(QWebFrame*)),
> +            this, SLOT(connectFrame(QWebFrame*)));

Make this a one liner


> +    connect(page, SIGNAL(loadFinished(bool)),
> +            m_controller, SLOT(maybeDump(bool)));

same as above

> +// Also count the main view

change to // Include the main view in the count

> +    return windows.count() + 1;
>  }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.