[Webkit-unassigned] [Bug 32103] Add zombies to JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32103


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44209|review?                     |review+
               Flag|                            |




--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2009-12-02 22:17:41 PST ---
(From update of attachment 44209)
> -#define COLLECT_ON_EVERY_ALLOCATION 0
> +#define COLLECT_ON_EVERY_ALLOCATION 1

Yeah, I don't think you mean that.  I'm only guessing.

> -                        imp->~JSCell();
> +#if ENABLE(JSC_ZOMBIES)
> +                        if (!imp->isZombie()) {
> +                            const ClassInfo* info = imp->classInfo();
> +#endif
> +                            imp->~JSCell();
> +#if ENABLE(JSC_ZOMBIES)
> +                            new (imp) JSZombie(info, JSZombie::leakedZombieStructure());
> +                            heap.numZombies++;
> +                        }
> +#endif

Personally I think this might be a little nicer as:

#if ENABLE(JSC_ZOMBIES)
                        if (!imp->isZombie()) {
                            const ClassInfo* info = imp->classInfo();
                            imp->~JSCell();
                            new (imp) JSZombie(info,
JSZombie::leakedZombieStructure());
                            heap.numZombies++;
                        }
#else
                        imp->~JSCell();
#endif


BRRrrrraaaiiiiiinnnnzzzzzzzzzzzzzzzzzzzzz+

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.