[Webkit-unassigned] [Bug 32081] repaint events from outside the viewport aren't received

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32081


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44205|                            |review+
               Flag|                            |




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com>  2009-12-02 21:33:12 PST ---
(From update of attachment 44205)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog

> +2009-12-02  Rafael Antognolli  <antognolli at profusion.mobi>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        repaint events from outside the viewport aren't received
> +        https://bugs.webkit.org/show_bug.cgi?id=32081
> +

This Changelog entry needs to explain the justification for the change in more
detail.
What does it mean for a view to paint its entire contents? Why does it need to
be settable?

> diff --git a/WebCore/page/FrameView.cpp b/WebCore/page/FrameView.cpp

> +void ScrollView::setPaintsEntireContents(bool paint)
> +{
> +    m_paintsEntireContents = paint;
> +}

Parameter name could be improved: paintsEntireContents would be fine.

> +    if (!m_paintsEntireContents)

I have a slight preference for calling paintsEntireContents() here (it's
inline, so no extra overhead),
so this code matches the code in FrameView.

> diff --git a/WebCore/platform/ScrollView.h b/WebCore/platform/ScrollView.h
> index dbbbff1..e269678 100644
> --- a/WebCore/platform/ScrollView.h
> +++ b/WebCore/platform/ScrollView.h
> @@ -92,6 +92,9 @@ public:
>      virtual void setCanHaveScrollbars(bool);
>      bool canHaveScrollbars() const { return horizontalScrollbarMode() != ScrollbarAlwaysOff || verticalScrollbarMode() != ScrollbarAlwaysOff; }
>  
> +    bool paintsEntireContents() const { return m_paintsEntireContents; }
> +    void setPaintsEntireContents(bool flag);

You can omit the parameter name here in the header. I'd like to see a comment
here explaining the purpose of the 'paintsEntireContents' behavior.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.