[Webkit-unassigned] [Bug 23846] [GTK]Enable DNS prefetching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23846


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43782|review?                     |review+
               Flag|                            |




--- Comment #19 from Gustavo Noronha (kov) <gns at gnome.org>  2009-12-02 10:20:35 PST ---
(From update of attachment 43782)
>  #include "config.h"
> +#include "CString.h"
>  #include "DNS.h"
> -
> -#include "NotImplemented.h"
> +#include "ResourceHandle.h"

As pointed out by the review queue, the CString.h header should be just before
ResourceHandle.h, and there should indeed be a blank line between #include
"DNS.h" and the CString include.

>  void prefetchDNS(const String& hostname)
>  {
> -    notImplemented();
> +    String uri = "http://"+hostname;
> +    SoupURI* soupUri = soup_uri_new(uri.utf8().data());
> +    soup_session_prepare_for_uri(ResourceHandle::defaultSession(), soupUri);
> +    soup_uri_free(soupUri);
>  }

How about using GOwnPtr here? r=me with whatever you decide in this regard, and
with the style problems fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.