[Webkit-unassigned] [Bug 32061] New: REGRESSION(51590): style-queue and build-queue think their empty when they are not

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32061

           Summary: REGRESSION(51590): style-queue and build-queue think
                    their empty when they are not
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org


style-queue and build-queue think their empty when they are not

This is due to a regression from r51590.  In fetch_attachment, we depend on
attachment['id'] == attachment_id.  Thats not true if one is an int and the
other is a string.

Lets fix all ids to be ints, and update the unit tests accordingly.  The unit
test I was fixing in r51590 was wrong.

For now I'm papering over the comparison problem because fetch_attachment is
very difficult to test due to there being no network abstraction in bugzilla
that I can Mock out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.