[Webkit-unassigned] [Bug 31617] WebSocket handshake doesn't check query component of URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31617





--- Comment #27 from Fumitoshi Ukai <ukai at chromium.org>  2009-12-02 00:29:46 PST ---
(In reply to comment #25)
> (From update of attachment 44127 [details])
> r=me, thanks for adding all these tests!

Thanks for review!

> 
> It worries me that accidentally using localhost instead of 127.0.0.1 didn't
> dramatically affect test behavior. It doesn't necessarily indicate a problem,
> but we need to add many new tests for cross-origin WebSocket usage to check
> that it functions correctly.

I've file a bug https://bugs.webkit.org/show_bug.cgi?id=32055.
I'll work on this.

> Per-function comments in WebCore/ChangeLog would be appreciated. The change to
> KURL::query() is particularly interesting, as someone working on bug 21015 will
> need to know the rationale of the change you're making here, and won't find it.

Sure. Added comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.