[Webkit-unassigned] [Bug 31617] WebSocket handshake doesn't check query component of URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31617


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44127|review?                     |review+
               Flag|                            |




--- Comment #25 from Alexey Proskuryakov <ap at webkit.org>  2009-12-01 23:41:27 PST ---
(From update of attachment 44127)
r=me, thanks for adding all these tests!

It worries me that accidentally using localhost instead of 127.0.0.1 didn't
dramatically affect test behavior. It doesn't necessarily indicate a problem,
but we need to add many new tests for cross-origin WebSocket usage to check
that it functions correctly.

Per-function comments in WebCore/ChangeLog would be appreciated. The change to
KURL::query() is particularly interesting, as someone working on bug 21015 will
need to know the rationale of the change you're making here, and won't find it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.