[Webkit-unassigned] [Bug 32048] [chromium] theme scrollbars to match gtk theme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32048


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44125|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-12-01 20:29:24 PST ---
(From update of attachment 44125)
Would be nice to document the pixel format.  "unsigned" doesn't tell the reader
much.  I'm kinda surprised we don't have a WebColor with all the other Web*
we've got. :)

I'm surprised we don't already ahve something like saturateAndBrighten in
Color.h

I would have written:
 86     if (color[1] > 1.0)
 87         color[1] = 1.0;
 88     else if (color[1] < 0.0)
 89         color[1] = 0.0;

as:
color[1] = std::min(std::max(hsv[1] + saturateAmount, 0.0), 1.0)

Ha.  If you don't like my min/max above, at least write a function do do it,
cause you repeat the same 4 lines everywehre:
if (min_diff < 0.2)
 131         min_diff = 0.2;
 132     else if (min_diff > 0.5)
 133         min_diff = 0.5;

Style viloations:
inactive_color

I'm surprised check-webkit-style doesn't get those.  I guess I'll file a bug.

Otherwise looks good!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.