[Webkit-unassigned] [Bug 21288] Implement HTML5's sandbox attribute for iframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21288





--- Comment #61 from Darin Adler <darin at apple.com>  2009-12-01 11:32:13 PST ---
(In reply to comment #60)
> Copying the flags from the creating frame would probably be safe.
> However, there are quite many locations where SecurityOrigins are
> instantiated (about 20 sites, 10 classes in different parts of
> WebCore).  Each of these locations would need modification to locate
> the creating frame, and I don't currently know of a common way to do
> that.
> 
> I'm not sure there is any added safety in this anyway.  Sandbox flags
> have no meaning without a frame context (in my interpretation of HTML5
> at least).

I do not want this issue to block the patch. But separate from this patch, I
think we should not drop this.

I suggest that we set the sandbox flags on such documents to a value that means
"this document has no sandboxing context" by default. And put assertions into
sandbox-flag-checking accessors to make sure such flags are never checked. If
they are checked, then I want to understand why it's OK to have the values
initialized to the liberal "allow anything" value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.