[Webkit-unassigned] [Bug 31617] WebSocket handshake doesn't check query component of URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31617


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44052|review?                     |review-
               Flag|                            |




--- Comment #22 from Alexey Proskuryakov <ap at webkit.org>  2009-12-01 09:37:18 PST ---
(From update of attachment 44052)
+# Missing "WebSocket is closed"

I don't think this is still needed - bug 31659     is fixed now.

+var url = "ws://user:pass@localhost:8880/websocket/tests/echo-location";

Are you testing cross-origin WebSocket here? HTTP tests run from 127.0.0.1, not
from localhost, so accessing localhost is cross origin. Are WebSocket tests
different?

+String KURL::resourceName() const

Now that I see where "resource name" is defined, I'm positive that this
accessor shouldn't be added to KURL. Resource name is solely a Web Sockets
concept, so it should be confined to Web Sockets code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.