[Webkit-unassigned] [Bug 32024] New: [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32024

           Summary: [GTK] WebKit does not compile without
                    JAVASCRIPT_DEBUGGER
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung at gmail.com


Created an attachment (id=44085)
 --> (https://bugs.webkit.org/attachment.cgi?id=44085)
patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk

When I try to build webkit without ENABLE(JAVASCRIPT_DEBUGGER), there are some
problems. 

First, even though I run './configure --enable-javascript-debugger=no', the
ENABLE(JAVASCRIPT_DEBUGGER) is still enabled. I'm going to report the reason.

Second, when I defined 'ENABLE_JAVASCRIPT_DEBUGGER 0' as IPHONE, ANDROID in
wtf/Platform.h, there are two build errors as below, 

-f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1;
fi
WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void
webkit_web_inspector_set_property(GObject*, guint, const GValue*,
GParamSpec*)':
WebKit/gtk/webkit/webkitwebinspector.cpp:353: error: 'class
WebCore::InspectorController' has no member named 'enableProfiler'
WebKit/gtk/webkit/webkitwebinspector.cpp:355: error: 'class
WebCore::InspectorController' has no member named 'disableProfiler'
WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void
webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)':
WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class
WebCore::InspectorController' has no member named 'profilerEnabled'
make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1
make[1]: Leaving directory `/root/workspace/WebKit'
make: *** [all] Error 2

Tpo" "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Plo"; else rm
-f "WebKit/gtk/webkit/.deps/libwebkit_1_0_la-webkitwebinspector.Tpo"; exit 1;
fi
WebKit/gtk/webkit/webkitwebinspector.cpp: In function 'void
webkit_web_inspector_get_property(GObject*, guint, GValue*, GParamSpec*)':
WebKit/gtk/webkit/webkitwebinspector.cpp:388: error: 'class
WebCore::InspectorController' has no member named 'profilerEnabled'
make[1]: *** [WebKit/gtk/webkit/libwebkit_1_0_la-webkitwebinspector.lo] Error 1
make[1]: Leaving directory `/root/workspace/WebKit'
make: *** [all] Error 2

The reason of upper build errors is that webkitwebinspector.cpp still invokes
the enableProfiler(), disableProfiler() and profilerEnabled() defined in
WebCore/inspector/InspectorController.h.
In my opinion, it seems embedded device based on gtk doesn't need to use
JAVASCRIPT_DEBUGGER feature.

I make a try a patch for webkitwebinspector.cpp. If there are any nits or
problems, please let me know.

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.