[Webkit-unassigned] [Bug 23526] clipToImageBuffer() for all platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23526





--- Comment #8 from Dirk Schulze <krit at webkit.org>  2009-12-01 00:28:37 PST ---
(In reply to comment #7)
> I think we could do this clearer by saving the mask image on the
> GraphicsContextState and applying it during m_data->restore();
> You could write a new applyMaskImage() function on m_data which does the actual
> apply using the stored image.   the mask image would not inherit between
> graphics context states.
> 
> Does that seem sane?

A new GraphicsContextState is the copy of a previous one, so every content gets
copied too. This is impossible for ImageBuffers. So we can't store ImageBuffers
into the state, but even references will be copied. That means we still need
something that counts the save/restores as well as the number of
clipToImageBuffer calls. That is what the current patch is doing (Vector of
int). With pushing the context I move the store operation out of webkit into
cairo. That makes it possibly clearer.

applyMaskImage sounds reasonable, but it doesn't change anything on the general
problem. It would just move the code out of restorePlatformState.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.