[Webkit-unassigned] [Bug 28851] New: Emit last progress notification before calling dispatchDidFinishLoad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28851

           Summary: Emit last progress notification before calling
                    dispatchDidFinishLoad
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com


When a frame finishes loading the last batch of progress reports and status
signals goes like this:

... 80%, 90%, FINISHED, 100%.

This is because the code in FrameLoader::checkLoadCompleteForThisFrame will
call first progressCompleted() and then dispatchDidFinishLoad(). IMHO this goes
against the natural expectation of receiving all the progress reports before
the FINISHED notification, so I propose to reverse the order of the function
calls. The attached patch does that, and does not seem to regress any layout
tests here.

This surely should get some tests with it, but I'm not sure of what should I be
testing, so suggestions are welcome.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.