[Webkit-unassigned] [Bug 27899] [Gtk] Expose a database API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27899





--- Comment #12 from Gustavo Noronha (kov) <gns at gnome.org>  2009-08-31 05:36:15 PDT ---
(In reply to comment #10)
> (In reply to comment #9)
> 
> Thanks for the feedback. I have a few comments below and should be able to
> submit another patch soon fixing the other issues.

OK, sorry I didn't reply on IRC, I reviewed the patch and went to sleep,
straight =)

> This signal is for parity with other ports' delegates and it's needed by DRT.
> I'm not sure if there is a good way to track database usage as a GObject
> property with the current WebCore API, but I could be wrong.

Yeah, that makes sense.

> > > + * WebKit uses SQLite to create and access the local SQL databases. The location
> > > + * of a #WebKitWebDatabase can be accessed wth #webkit_web_database_get_path.
> > > + * You can configure the location of all databases with
> > > + * #webkit_set_database_directory_path.
> > 
> > That's pretty inconsistent. I do think these two should be
> > webkit_get/set_web_database_path, since they are not acting on a specific
> > web_database, or are they?
> 
> The first gets the full path to the SQLite file for the database and the latter
> gets the path to the parent directory for all SQLite web database files.
> Perhaps there is a way I can clarify this?

I think you can say 'specific file' in the first one. 

> > The path of the specific file? I am not sure what this property is supposed to
> > represent. It looks like we would want a filename here, that would be joined
> > with the global databases directory obtained by a webkit_get_web_database_path
> > call.
> 
> We may have to return the full path. I'm not sure the API exposes the way to
> get from /path/to/all/databases to
> /path/to/all/databases/various/subdirectories/0000000000000002.db-journal.
> Subdirectories are used to separate database files by origin. I'll try to
> improve the doc here though.

I see. Yeah, I would suggest using 'filename' instead of path, and say in the
documentation that it's the absolute filename.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.