[Webkit-unassigned] [Bug 28038] WebSocket API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28038





--- Comment #14 from Fumitoshi Ukai <ukai at chromium.org>  2009-08-31 03:31:29 PDT ---
Thanks for review.

(In reply to comment #10)
> Coding style looks reasonably close to me now. One thing I did notice is that
> "Websocket" is still used in several places - since it's two words, it should
> be "WebSocket".
> 
> The biggest challenge left is to discuss naming of data and methods in
> WebSocketHandshake - currently, there are several of names that seem difficult
> to understand or maybe even misleading. It's also not yet clear to me how
> redirects and authentication are supported. I'll need to read the relevant
> parts of the spec more closely.

I've updated a patch.
Could you tell me what data and methods are difficult to understand or
misleading?  I'll fix them.

For authentication, I think we need some interface to obtain Credential for the
relevant URL over http, to get AuthenticationChallenge from Authorization
header or something like that.  What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.