[Webkit-unassigned] [Bug 28828] Make SVGStyleElement title/media/type setters do something

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28828


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38774|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-31 03:17:14 PDT ---
(From update of attachment 38774)
shouldBeEqualToString will make your life easier here:
 5 shouldBe("style.type", "'text/css'");

shouldBeEqualToString("style.type", "text/css");

Normally we would use longer argument names here:
 53 void SVGStyleElement::setXmlspace(const AtomicString& s, ExceptionCode&)
like "space"

and "type":
 65 void SVGStyleElement::setType(const AtomicString& s)

Why not just remove "setter raises()"?
 33                      /*setter raises(DOMException)*/;

Are these spec'd to raise, but they never should?  If so, please explain in
your ChangeLog.

In general this looks great!  If you were a committer, I would r+ and you could
land with changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.