[Webkit-unassigned] [Bug 28830] [Gtk] DRT needs implementation of overridePreference

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28830


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38780|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-31 03:13:56 PDT ---
(From update of attachment 38780)
Looks great!

I would have named "toWebSettingKey" "copyAsWebSettingKey" or something.  To
inform the caller that they need to release the returned string.

It's so sad that we don't have some sort of GOwnPtr for DRT to use here instead
of needing to manually g_free.

Spacing:
+            if ( !(ss >> val).fail())

+    static gboolean isInitialized = false;
is not really needed, you can check !keyTable.

Please adjust a little before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.