[Webkit-unassigned] [Bug 28831] Make ElementTimeControl methods return void and not throw

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28831


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38781|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-31 03:10:26 PDT ---
(From update of attachment 38781)
Looks great!  I assume the spec must have changed from when we wrote these?

Looks good except for lack of testing.  r- for lack of tests.  Just something
simple to make sure these return undefined would be sufficient.

DOM-only tests would be best for these:
http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree

shouldBeUndefined("svg.beginElement()");
shouldBeUndefined("svg.beginElementAt(NaN)");
shouldBeUndefined("svg.endElement()");
shouldBeUndefined("svg.endElementAt(NaN)");
etc.

Thanks for the patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.