[Webkit-unassigned] [Bug 28835] [Haiku] Correction of native image creating.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28835


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38792|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-31 03:04:54 PDT ---
(From update of attachment 38792)
The ChangeLog really needs a clearer description of why you're doing this.  The
code might benefit from similar comments.

I would probably have pre-computed the source and dest into nicely named locals
first:
         memcpy(static_cast<uint8*>(bmp->Bits()) + y * bmp->BytesPerRow(),
 42                reinterpret_cast<const uint8*>(m_bytes.data()) + y *
bytesPerRow, minBytesPerRow);

r- for an unclear ChangeLog.

How is the B_RGBA32 storage different from WebCore's?  Should we be using some
sort of COMPILE_ASSERTs here to verify the current assumptions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.