[Webkit-unassigned] [Bug 26409] [GTK] Glitches in new progress/load-status system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26409





--- Comment #11 from Xan Lopez <xan.lopez at gmail.com>  2009-08-31 02:32:35 PDT ---
(In reply to comment #10)
> > - FINISHED comes before 100% progress is reported. I believe the natural
> > expectation would be to receive 100% while the status is still not finished,
> > and *then* receive FINISHED.
> 
> The FrameLoadClientGtk relies on FrameLoader. And FrameLoader actually has
> guards to catch this case, so it looks like a bug in WebCore. I mostly hacked
> the Gtk bits so I can't easily say where to look.  I guess this needs some
> looking at debugging output.

It does not seem to be a bug but a deliberate decision. This patch fixes it:

diff --git a/WebCore/loader/FrameLoader.cpp b/WebCore/loader/FrameLoader.cpp
index 4530c11..f187b5d 100644
--- a/WebCore/loader/FrameLoader.cpp
+++ b/WebCore/loader/FrameLoader.cpp
@@ -3386,13 +3386,14 @@ void FrameLoader::checkLoadCompleteForThisFrame()
 #ifndef NDEBUG
             m_didDispatchDidCommitLoad = false;
 #endif
+            if (Page* page = m_frame->page())
+                page->progress()->progressCompleted(m_frame);
+
             if (!error.isNull())
                 m_client->dispatchDidFailLoad(error);
             else
                 m_client->dispatchDidFinishLoad();

-            if (Page* page = m_frame->page())
-                page->progress()->progressCompleted(m_frame);
             return;
         }

I guess I'll poke someone to see if it would be reasonable to change this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.