[Webkit-unassigned] [Bug 28842] New: [GTK] Do not emit extra FINISHED load-status signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28842

           Summary: [GTK] Do not emit extra FINISHED load-status signals
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com


We are emitting extra finished load-status signals when loading pages that will
error. Example of the current flow:

- Try to load bogus page

** (epiphany:30316): DEBUG: NOTIFY STATUS PROVISIONAL about:blank
** (epiphany:30316): DEBUG: dispatchDidFailProvisionalLoad

dispatchDidFailProvisionalLoad calls dispatchDidFailLoad

** (epiphany:30316): DEBUG: dispatchDidFailLoad

- The load fails, we start loading the error page

** (epiphany:30316): DEBUG: NOTIFY STATUS PROVISIONAL about:blank

- dispatchDidFailLoad emits FINISHED

** (epiphany:30316): DEBUG: NOTIFY STATUS FINISHED about:blank

- dispatchDidFailProvisionalLoad *also* emits FINISHED

** (epiphany:30316): DEBUG: NOTIFY STATUS FINISHED about:blank

- The error page loads succesfully

** (epiphany:30316): DEBUG: NOTIFY STATUS COMMITTED http://suaoehuoeuh.com/
** (epiphany:30316): DEBUG: NOTIFY STATUS FIRST_VISUALLY_NON_EMPTY_LAYOUT
http://suaoehuoeuh.com/
** (epiphany:30316): DEBUG: NOTIFY STATUS FINISHED http://suaoehuoeuh.com/

Basically, I don't think there's a reason we should emit the FINISHED status
ourselves, we receive those we need to emit from WebCore. Removing that we get:

** (epiphany:27885): DEBUG: NOTIFY STATUS PROVISIONAL about:blank
** (epiphany:27885): DEBUG: dispatchDidFailProvisionalLoad
** (epiphany:27885): DEBUG: dispatchDidFailLoad
** (epiphany:27885): DEBUG: NOTIFY STATUS PROVISIONAL about:blank
** (epiphany:27885): DEBUG: NOTIFY STATUS COMMITTED http://usoethuoeau.com/
** (epiphany:27885): DEBUG: NOTIFY STATUS FIRST_VISUALLY_NON_EMPTY_LAYOUT
http://usoethuoeau.com/
** (epiphany:27885): DEBUG: NOTIFY STATUS FINISHED http://usoethuoeau.com/

Which goes from PROVISIONAL to FINISHED, with one extra PROVISIONAL in the
middle (which is ok) because the original page failed loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.