[Webkit-unassigned] [Bug 28823] [GTK] New events (pageshow and pagehide) tests failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28823





--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2009-08-29 21:15:35 PDT ---
(From update of attachment 38782)
> +    /**
> +     * WebKitWebSettings:enable-page-cache
> +     *
> +     * Whether to enable the page cache
> +     *
> +     * Since 1.1.14
> +     */
> +    g_object_class_install_property(gobject_class,
> +                                    PROP_ENABLE_PAGE_CACHE,
> +                                    g_param_spec_boolean("enable-page-cache",
> +                                                         _("Enable Page Cache"),
> +                                                         _("Whether to enable the page cache"),
> +                                                         TRUE,
> +                                                         flags));

If this is causing trouble, why would we enable this by default? Better to have
a comment saying that we plan to enable this by default in the future?

API-wise, except for the default, fine with me. =)

> -                         g_str_equal(g_utf8_strdown(strValue, -1), "true"),
> +                         g_str_equal(g_utf8_strdown(strValue, -1), "true")
> +                         || g_str_equal(g_utf8_strdown(strValue, -1), "1"),
>                           NULL);
>          } else if (G_VALUE_HOLDS_INT(&propValue)) {
>              std::string str(strValue);

Weird. Why do we need this now?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.