[Webkit-unassigned] [Bug 28814] New: -[WebViewFactory AXARIAContentGroupText:] seems fragile and not cross-platform-friendly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28814

           Summary: -[WebViewFactory AXARIAContentGroupText:] seems
                    fragile and not cross-platform-friendly
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: sullivan at apple.com, cfleizach at apple.com


When a new ARIA group role is added, both AccessibilityObjectWrapper.mm and
WebViewFactory.mm will need to be updated to provide a new description string
for the new role. But because -[WebViewFactory AXARIAContentGroupText:] takes a
string parameter describing the role, it will be easy to forget to update both
places (e.g., someone could update AccessibilityObjectWrapper.mm but forget to
update WebViewFactory.mm).

This would be less fragile if we had a separate WebViewFactory method for each
ARIA group role, rather than a single method that takes the role as a
parameter.

A side benefit of this is that all other ports will be aware of all the role
description strings they need to provide, rather than having to look at
WebViewFactory.mm to figure it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.