[Webkit-unassigned] [Bug 28709] [V8] Made bindings use Node::setOnEvent functions for Node descendants instead of Node::setAttributeEventListener.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28709





--- Comment #10 from Sam Weinig <sam at webkit.org>  2009-08-28 10:30:32 PDT ---
(In reply to comment #6)
> (In reply to comment #4)
> > A better solution here is to make V8 bindings use an approach similar to JSC
> > and to make the function private. I'll post an updated patch soon.
> 
> Sam,
> 
> The cleanup part of this turns out be less trivial than changing the visibility
> modifier of Node::{set,get,clear}AttributeEventListener. These functions are
> called by classes that are neither from V8 bindings (which I fixed) nor Node
> descendants. All these calls use statically known event names (i.e. they all
> look like node->getAttributeEventListener(eventNames().foo)), but some of these
> event names have no corresponding Node::{setOn,on}Event accessors. So I think
> Node::{set,get,clear}AttributeEventListener have to stay unchanged.

Ok, that makes sense.  As long as the bindings code doesn't depend on them, I
think we will be good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.