[Webkit-unassigned] [Bug 28806] New: [Qt] Make the WebInspector available as a widget class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 06:44:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28806

           Summary: [Qt] Make the WebInspector available as a widget
                    class.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jocelyn.turcotte at nokia.com
                CC: ariya.hidayat at trolltech.com


Allows users of QtWebKit to control the location of the WebInspector and to
dock it.

Notes about this modification in InspectorController:

 void InspectorController::setWindowVisible(bool visible, bool attached)
 {
-    if (visible == m_windowVisible)
+    if (visible == m_windowVisible || !m_frontend)
         return;

     m_windowVisible = visible;

-    if (!m_frontend)
-        return;
-
     if (m_windowVisible) {
         setAttachedWindow(attached);
         populateScriptObjects();


It prevented correct initialization of the web inspector when calling
setWindowVisible two times rapidly on first calls.
After verification, all code path with the state (m_windowsVisible &&
!m_frontend) would lead to a crash or not accomplishing any action.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list