[Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast

Thu Aug 27 23:28:29 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28667

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38454|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-08-27 23:28:29 PDT ---
(From update of attachment 38454)
LGTM.

I've got 2 nits though:

1. You mentioned that this is not technically "memoization" but rather caching.
 If so, let's call it CachingURLCanonicalizer and m_cachedURL (and maybe
m_inputURL?)

2.  seems strange to change some decodeHTMLentities to decodeEntities and
others to decodeHTMLEntities.  Pick one. :)  I suggest "decodeEntities".

I don't need to see this again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.