[Webkit-unassigned] [Bug 28742] [Chromium] Combining Diacritical Marks (U+0300..) are not handled correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28742





--- Comment #10 from Yusuke Sato <yusukes at chromium.org>  2009-08-27 21:13:40 PDT ---
Thanks for the review!

> We can get rid of the delete() code by using:
> OwnPtr<TextRun> m_normalizedRun;
> OwnArrayPtr<UChar> m_normalizedBuffer;

Done.

> In fact, then it still could be a const TextRun&, it doesn't need to change to
> be a pointer (although it can be made one if you feel that's cleaner).

Changed it back to const TextRun&.

> if (U_FAILURE(error))
>     return;

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.