[Webkit-unassigned] [Bug 28742] [Chromium] Combining Diacritical Marks (U+0300..) are not handled correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28742


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38623|review?                     |review-
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-08-27 13:43:55 PDT ---
(From update of attachment 38623)
Two nits:

We can get rid of the delete() code by using:
OwnPtr<TextRun> m_normalizedRun;
OwnArrayPtr<UChar> m_normalizedBuffer;

Then you just set m_run = m_normalizedRun.get();

In fact, then it still could be a const TextRun&, it doesn't need to change to
be a pointer (although it can be made one if you feel that's cleaner).

This should use early return:
316         if (U_SUCCESS(error)) {

if (U_FAILURE(error))
     return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.