[Webkit-unassigned] [Bug 22920] Inspector Request Headers Should Show Data/Variables/Parameters Sent With Request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22920


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38550|review?                     |review-
               Flag|                            |




--- Comment #22 from Timothy Hatcher <timothy at hatcher.name>  2009-08-27 08:56:49 PDT ---
(From update of attachment 38550)

> +    this.requestMethod = requestMethod || "";
> +    this.requestFormData = requestFormData || "";

Is this needed, can they be null/undefined?

> +        var parmString = url.split("?",2)[1];

Need a space after the comma (a few places like this in the patch.)


> +            if (testKey.toLowerCase() == lowerKey) {

Triple equals would be best. No need for the braces.

> +        return undefined;

Just remove this and let the default undefined return happen.

> +        title += "<div style='white-space:pre-wrap' class='header-value'>" + formData.escapeHTML() + "</div>";

You should add a style class to the inspector.css and not have this inline
style. Use double quotes for the HTML too.

> +        for (var i = 0; i < parms.length; i++) {

Use ++i.

> +            parm = parm.split("=",2);

Space after the comma.

> +            if (parm.length == 1) parm.push("");

Should be on two lines.

> +            var tooltip;
> +            if (val.indexOf("%") >= 0) {
> +                tooltip = decodeURIComponent(val).replace("+"," ");
> +            }

No need for the braces. I think we should show decoded by default. I like Joe's
idea of a way to toggle the representations inline so they can be copied. I
don't think a tooltip is useful, but maybe a tooltip showing the size in
bytes/KB/MB is.

> +            if (tooltip) parmTreeElement.tooltip = tooltip;

Should be on two lines, if we need it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.