[Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28131





--- Comment #35 from Ryan Leavengood <leavengood at gmail.com>  2009-08-26 14:16:59 PDT ---
(In reply to comment #34)
> 
> I probably wouldn't have bothered to maintain these copyrights after such
> extensive modification:
> 2  * Copyright (C) 2006 Apple Computer, Inc.
>  3  * Copyright (C) 2006 Zack Rusin <zack at kde.org>
>  4  * Copyright (C) 2006 Dirk Mueller <mueller at kde.org>
>  5  * Copyright (C) 2006 Nikolas Zimmermann <zimmermann at kde.org>
>  6  * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
>  7  * Copyright (C) 2009 Maxime Simon <simon.maxime at gmail.com>

I was always pretty worried about this in my original port as copyright stuff
can be pretty tricky, especially in the US. But if you think it is OK, I say
Maxime can probably remove most of those (maybe even me.)

> This is going to need at least one more round of review since there were still
> obvious leaks in this one. :(  Do you all have any way to check for leaks on
> Haiku?

I at least tried rigging up a LeakChecker.h that overrode new and delete for
our work on the new browser, but it didn't work that well in my testing. We
could definitely work to improve this area though, as memory leaking in
browsers has always really, really annoyed me. It wouldn't do to have my
browser so leaky!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.