[Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28675


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mitz at webkit.org




--- Comment #6 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-08-26 05:39:08 PDT ---
(In reply to comment #5)
> > > +sub propertyChangeDescription($)
> > > ... 
> > I would rather see all property changes listed if there are more than one. 
> > Please update this method to list all the property changes and just append the
> > formatted strings to a $result string.
> 
> OK I've made it output all changed properties.
> 
> It still only describes the property changes if there are no changes to the
> file contents, though.  Do you think that's the preferred thing to do?  Or
> should it always list the property changes?  One thing that looks confusing is
> if the file was modified and properties were changed.  Since the description
> for a file modification is empty, the description of the property changes by
> itself makes it look like that's the only change.

Hmm...I think it would be nice to list all property changes regardless of other
changes to the file.  When a new file is added, I think the main entry for the
file says "Added.", but all the new methods are also listed.  We could do
something similar for properties.

Ultimately, the patch author has the responsibility to update the ChangeLog
entry, so I think it's best to give them all the information possible (as long
as the default behavior can also be used without modification).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.