[Webkit-unassigned] [Bug 28707] [Chromium] Complex text doesn't show up with text stroking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28707


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38600|review?                     |review-
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-08-25 23:40:00 PDT ---
(From update of attachment 38600)
> +2009-08-25  Yusuke Sato  <yusukes at chromium.org>
...
> +        Added extra NULL checks for HDC. This is the second fix for issue 28707,
> +	and the fix is similar to http://trac.webkit.org/changeset/45482.

nit: please do not include tabs in the ChangeLog.  R- for this reason.


> +++ b/WebCore/platform/graphics/chromium/UniscribeHelper.cpp

> +            if (dc) {
> +                if (firstRun) {
> +                    oldFont = SelectObject(dc, shaping.m_hfont);
> +                    firstRun = false;
> +                } else
> +                    SelectObject(dc, shaping.m_hfont);
> +            }

This is OK, but maybe it should use the useWindowsDrawing local variable
instead just as the code within the for loop does.  What do you think?

-Darin

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.