[Webkit-unassigned] [Bug 28727] New: Gtk Build broken for OSX Quartz

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28727

           Summary: Gtk Build broken for OSX Quartz
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Blocker
          Priority: P1
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jralls at ceridwen.us


Building WebKit for GTK fails:
WebCore/plugins/PluginView.cpp: In member function ‘NPError
WebCore::PluginView::setValue(NPPVariable, void*)’:
WebCore/plugins/PluginView.cpp:439: error: ‘m_drawingModel’ was not declared in
this scope
WebCore/plugins/PluginView.cpp:463: error: ‘m_eventModel’ was not declared in
this scope
WebCore/plugins/PluginView.cpp: In constructor
‘WebCore::PluginView::PluginView(WebCore::Frame*, const WebCore::IntSize&,
WebCore::PluginPackage*, WebCore::Element*, const WebCore::KURL&, const
WTF::Vector<WebCore::String, 0ul>&, const WTF::Vector<WebCore::String, 0ul>&,
const WebCore::String&, bool)’:
WebCore/plugins/PluginView.cpp:627: error: class ‘WebCore::PluginView’ does not
have any field named ‘m_drawingModel’
WebCore/plugins/PluginView.cpp:628: error: class ‘WebCore::PluginView’ does not
have any field named ‘m_eventModel’
WebCore/plugins/PluginView.cpp:649: error: ‘m_npCgContext’ was not declared in
this scope

(The line numbers are not correct for the current trunk; they refer to release
1.1.12. The underlying problem described below still exists.)

It does so because PluginView.h contains the lines:
#if PLATFORM(GTK) || defined(Q_WS_X11)
        void setNPWindowIfNeeded();
#elif defined(XP_MACOSX)
        NP_CGContext m_npCgContext;
        OwnPtr<Timer<PluginView> > m_nullEventTimer;
        NPDrawingModel m_drawingModel;
        NPEventModel m_eventModel;

        void setNPWindowIfNeeded();
        void nullEventTimerFired(Timer<PluginView>*);
        Point globalMousePosForPlugin() const;
#endif

 and PluginView.cpp has:

#if defined(XP_MACOSX)
    case NPPVpluginDrawingModel: {
        // Can only set drawing model inside NPP_New()
        if (this != currentPluginView())
           return NPERR_GENERIC_ERROR;

        NPDrawingModel newDrawingModel = NPDrawingModel(uintptr_t(value));
        switch (newDrawingModel) {
        case NPDrawingModelCoreGraphics:
            m_drawingModel = newDrawingModel;
            return NPERR_NO_ERROR;

...

#if defined(XP_MACOSX)
    , m_drawingModel(NPDrawingModel(-1))
    , m_eventModel(NPEventModel(-1))
#endif

When building with GTK and target=quartz, both GTK and XP_MACOSX are true. This
was discussed at length in https://bugs.webkit.org/show_bug.cgi?id=17001. The
initial error was committed in r43633 and r46028 added the member variables
which induced the failure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.