[Webkit-unassigned] [Bug 27632] Expose text segmentation through JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27632


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38574|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-08-25 16:49:26 PDT ---
(From update of attachment 38574)
Ok, in general this looks fine.

+    VisiblePosition start = VisiblePosition(this->startPosition());
+    VisiblePosition end = VisiblePosition(this->endPosition());

Should just be:
+    VisiblePosition start(startPosition());
+    VisiblePosition end(endPosition());

I don't think this comment is really needed, but it's OK to leave too. :)
+    // Please refer to https://bugs.webkit.org/show_bug.cgi?id=27632 comment
#5 for the spec.

This comment doesn't add anything:
+        // Range expand.

If you were a committer, I would just r+ and you could fix those nits on
landing.  As is, it would be best if you could post one final patch. :)

Thanks!  Sorry I missed these on the first round.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.