[Webkit-unassigned] [Bug 28429] Adding Heap profiler page to Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28429


Mikhail Naganov <mnaganov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38566|                            |review?
               Flag|                            |




--- Comment #12 from Mikhail Naganov <mnaganov at chromium.org>  2009-08-25 13:40:00 PDT ---
Created an attachment (id=38566)
 --> (https://bugs.webkit.org/attachment.cgi?id=38566)
Proposed patch to start adding Heap profiler UI behind a flag

Timothy, to be sure that we're on the same page, here is a patch that adds some
needed UI elements to Profiler page behind a flag. When the functionality
needed will be exposed by JSC, all branches will be removed.

I decided that instead of using a filter as on Resources tab, it is more
convenient to use groups on the sidebar (as on the Storage tab.) This approach
uses screen estate more effectively, as having a filter pane for just two types
of profiles is a waste of space.

See the screenshots of UI in the next attachment.

Some notes:
- although side pane groups are collapsible, this isn't reflected in UI (on
Storage tab too), I think this needs to be fixed separately;
- instead of "Heap profiles" I'm using the term "Heap snapshot", as it is taken
instantly, as opposed to CPU profile;
- we need a glyph image for "Take heap snapshot" button, I'm not a designed, so
if you could draw it, this would be great.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.