[Webkit-unassigned] [Bug 27632] Expose text segmentation through JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27632


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38519|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2009-08-25 10:41:30 PDT ---
(From update of attachment 38519)
 else {
 1819         return;
 1820     }
no {}

No "return;" needed.

1     Position s = rangeCompliantEquivalent(start);
 1822     Position e = rangeCompliantEquivalent(end);
 1823     setStart(s.node(), s.deprecatedEditingOffset(), ec);
 1824     setEnd(e.node(), e.deprecatedEditingOffset(), ec);

That should be:

setStart(s.containerNode(), s.computeOffsetInContainerNode());
setEnd(e.containerNode(), e.computeOffsetInContainerNode());

no rangeCompliantEquivalent calls are needed if you use containerNode and
computeOffsetInContainerNode

deprecatedEditingOffset() is basically always the wrong call to use. In general
any call with "deprecated" in its name can be assumed to be. :)  The confusion
here is that soooo much code still uses deprecatedEditingOffset() :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.