[Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5863


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org,
                   |                            |krit at webkit.org




--- Comment #6 from Dirk Schulze <krit at webkit.org>  2009-08-24 23:34:22 PDT ---
(In reply to comment #5)
> (From update of attachment 38470 [details])
> I don't understand why these exist:
> char SVGRadiusXAttrIdentifier[] = "SVGRadiusXAttr";
>  33 char SVGRadiusYAttrIdentifier[] = "SVGRadiusYAttr";
Radius is one attribute, that may have one or two arguments. These lines create
the "virtual" attributes radiusX and radiusY to differ between the both values.
See also SVGGaussianBlurElement. radiusX and radiusY are not part of
svgattr.in, because they don't realy exist in the SVG Spec.

> Why the _?
> set_operatorBaseValue
> is this all to avoid "operator" in C++?
Yes, the set...BaseValue is gernerated by the attribute name and you can't name
the attribute operator. The way with the underscore is also use in
SVGFECompositeElement.

> 
> This seems wrong, no?
>  36         readonly attribute SVGAnimatedEnumeration _operator;
No, why should it be wrong? the attribute operator is an enumeration and
animateable. Because of the underscore see comments above. 

Can you please review the patch again eric? I would like to set the r? again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.