[Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28241


Andrew Scherkus <scherkus at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |scherkus at chromium.org




--- Comment #16 from Andrew Scherkus <scherkus at chromium.org>  2009-08-24 17:53:52 PDT ---
> diff --git a/WebCore/rendering/RenderThemeChromiumSkia.cpp b/WebCore/rendering/RenderThemeChromiumSkia.cpp
> index c8875dc..d66a4af 100644
> --- a/WebCore/rendering/RenderThemeChromiumSkia.cpp
> +++ b/WebCore/rendering/RenderThemeChromiumSkia.cpp
> @@ -571,6 +571,28 @@ bool RenderThemeChromiumSkia::paintMediaSliderTrack(RenderObject* object, const
>  #endif
>  }
>  
> +bool RenderThemeChromiumSkia::paintMediaVolumeSliderTrack(RenderObject* object, const RenderObject::PaintInfo& paintInfo, const IntRect& rect)
> +{
> +#if ENABLE(VIDEO)
> +    HTMLMediaElement* mediaElement = mediaElementParent(object->node());
> +    if (!mediaElement)
> +        return false;

You should probably check hasAudio() here unless you can guarantee this is
never called if/when hasAudio() is false

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.