[Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27371


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34875|review?                     |review-
               Flag|                            |




--- Comment #12 from Eric Seidel <eric at webkit.org>  2009-08-24 17:26:20 PDT ---
(From update of attachment 34875)
This line is in the middle of nowhere:
 5  * All rights reserved.

Not true:
 2  * This file is part of the DOM implementation for KDE.

Why?
 246 #undef isSentenceStop

I'm not sure what this syntax does:
 59     friend LanguageManager& languageManager();

Why std::map instead of HashMap?
static std::map<UINT, std::string>& codePageCharsets()
 65 {
 66     static std::map<UINT, std::string> cc;
 67     return cc;
 68 }

Indent:
214 TextCodecWince::TextCodecWince(const TextEncoding& encoding)
 215 : m_encoding(encoding)

Comments are likely needed here:
 231     if (codePage > 50000) {
 232         if ((codePage >= 50220 && codePage <= 50222)
 233             || codePage == 50225
 234             || codePage == 50227
 235             || codePage == 50229
 236             || codePage == 52936
 237             || codePage == 54936
 238             || (codePage >= 57002 && codePage <= 57001)
 239             || codePage == 65000 // UTF-7

We generally use full english words for variable names:
 293                         int rtn = encMbToWc(dst, (const unsigned
char*)bytes, srcEnd - bytes);
 294                         if (rtn >= 0)
(obviously we may have to adjust to avoid keywords here)

I dont' think explicit construction is needed here:
66     if (resultLength <= 0)
 467         return CString("?");

r-, mostly needing explanation as to why the std:: types, generally we only use
std:: algorithms, not types in WebCore.  IIRC that's due to compiling without
exceptions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.