[Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28670


Mark Rowe (bdash) <mrowe at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38478|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #20 from Mark Rowe (bdash) <mrowe at apple.com>  2009-08-24 16:53:20 PDT ---
(From update of attachment 38478)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 47695)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,20 @@
> +2009-08-23  Robert Sesek  <rsesek at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac
> +        https://bugs.webkit.org/show_bug.cgi?id=28670
> +
> +        Change the condition regarding the key modifier check for non-contiguous
> +        selection on a multi-value select from PLATFORM(MAC) to PLATFORM(DARWIN), so
> +        that Chromium works as expected on Mac.

This doesn't describe the change that was actually made, so it'll need to be
updated. The actual code change looks fine.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.