[Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28225


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laszlo.1.gombos at nokia.com




--- Comment #5 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-08-24 14:10:46 PDT ---
(In reply to comment #4)
> (In reply to comment #2)
> > None of our existing scripts in WebKitTools/Scripts use this approach.  If this
> > is a problem I don't see why we would only fix a single script.
> 
> Mark,
> You are right that this would fix only one script and if otherwise the fix is
> acceptable I am willing to change all scripts in the directory to use the same
> approach.
> 
> On the other hand, there is one other script (roll-over-ChangeLogs) which uses
> the same approach, so it can be argued that since it is ok for that script it
> should be ok for this script too.
> 
> I believe that the /usr/bin/env approach  does not make sense for standard
> shells (such as /usr/bin/sh), but may be useful for perl, python and ruby
> scripts where many incompatible versions may exist in the system.

Perhaps -for now - we should just do this for "top level" python scripts. I did
a quick search and I only found 3 scripts:

check-webkit-style, bugzilla-tool, run-webkit-unittests

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.