[Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16356





--- Comment #19 from Gustavo Noronha (kov) <gns at gnome.org>  2009-08-23 15:51:27 PDT ---
(From update of attachment 38455)
I like it, keep rocking =)

 222     if (m_errorOccured)
 223         return 0;
 224 
 225     float ret = 0.0;

Since you're initializing it here, you don't need to reset this in the else
block bellow this.

Actually, why not do an early return here instead:

225228     if (gst_element_query(m_playBin, query)) {

Make that check to !, print the error log, and return, after unref'ing the
object.

> -    GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0);
> +//    GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0);
>      m_videoSink = webkit_video_sink_new(m_surface);
>  
> -    g_object_set(m_playBin, "audio-sink", audioSink, NULL);
> +//    g_object_set(m_playBin, "audio-sink", audioSink, NULL);
>      g_object_set(m_playBin, "video-sink", m_videoSink, NULL);

I think this can be removed, indeed, instead of just being commented. We only
need to override the video sink. Except for these, I don't see a reason not to
r+ this. Anything specific keeping you from setting r? apart from a missing
ChangeLog, and lack of 'divinding' the patch into smaller patches? I believe
this patch has actually a good size, tbh.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.