[Webkit-unassigned] [Bug 28362] SVG Filter feComposite implementation is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28362


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35118|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Nikolas Zimmermann <zimmermann at kde.org>  2009-08-22 18:53:06 PDT ---
(From update of attachment 35118)
r+, some comments, before landing;

> +                  2008 Dirk Schulze <krit at webkit.org>
2009.

> +inline void arithmetic(const RefPtr<CanvasPixelArray>& srcPixelArrayA, CanvasPixelArray*& srcPixelArrayB,
> +                       const float& k1, const float& k2, const float& k3, const float& k4)
s/const float&/float/. We don't use this style in WebKit, even though it's
correct, there's no gain.


> +    FloatRect srcRect = FloatRect(0, 0, -1, -1);
Use (0.0f, 0.0f, -1.0f, -1.0f) to be consistent with other callsites.

> +    switch (m_type) {
> +        case FECOMPOSITE_OPERATOR_OVER:
> +        case FECOMPOSITE_OPERATOR_IN:
> +        case FECOMPOSITE_OPERATOR_OUT:
> +        case FECOMPOSITE_OPERATOR_ATOP:
> +        case FECOMPOSITE_OPERATOR_XOR:
> +        case FECOMPOSITE_OPERATOR_ARITHMETIC: {
Indention, case & switch should be aligned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.