[Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 22 13:29:45 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28154


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38434|review?                     |review+
               Flag|                            |




--- Comment #2 from Jan Alonzo <jmalonzo at gmail.com>  2009-08-22 13:29:44 PDT ---
(From update of attachment 38434)
Hi Xan

> +WebCore::EditingBehavior core(WebKitEditingBehavior type)
> +{
> +    return (WebCore::EditingBehavior)type;

Is it possible to use c++ style casts here?

>  
> +typedef enum {
> +    WEBKIT_EDITING_BEHAVIOR_MAC,
> +    WEBKIT_EDITING_BEHAVIOR_WINDOWS
> +} WebKitEditingBehavior;

Is it possible to add a COMPILE_ASSERT for these just in case of future
changes?

Thanks. r=me with those changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list