[Webkit-unassigned] [Bug 27571] [CSS3 Backgrounds and Borders] Add support for the "round" value for background-repeat

Fri Aug 21 16:04:56 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=27571

mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38397|review?                     |review-
               Flag|                            |

--- Comment #2 from mitz at webkit.org  2009-08-21 16:04:56 PDT ---
(From update of attachment 38397)
This patch makes EFillRepeat values require 3 bits, but does not update the
size of the m_repeat member of FillLayer, so assigning to it will clobber the
m_composite member. Thus I’m r-’ing.

Given bug 28635, I think it will no longer make sense to capture all 16
possible combinations of no-repeat/repeat/space/round with one enum. Instead, I
think you should split m_repeat into two fields, one for horizontal repeat and
one for vertical repeat. Perhaps you should fix bug 28635 first. Then adding
space/round will be simple again (as simple as this patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.